Review main Merged

57121[FEATURE] Auto create management DB fields from TCA ctrl

Christian Kuhn CR +2 V +2 Nightmare +2901 −2462 updated 06/22/18, 17:20

Commit message

Adds a class that auto creates TYPO3 "management" related database
columns and indexes based on TCA 'ctrl' information without having
them specified in ext_tables.sql. The feature .rst file outlines
field details.

Goals:
* Save extension developers time.
* Less copy+paste issues and different general fields definitions.
* Reduce number of boilerplate fields in ext_tables.sql.
* Bring schema of management fields under core control.

Non goals:
* No full substitution of ext_tables.sql by TCA: "Business"
  fields from 'columns' are NOT created automatically. This
  would require further thoughts and code disentangling.
* No new extension API.
* No "migration" approach or similar.

Notable patch details:
* The patch is a revamped version of issue #81234 that has been
  abandoned. As requested in the review of #81234, the code now
  hooks in after ext_tables.sql has been parsed into the doctrine
  schema.
* Field defintions of ext_tables.sql take precedence, auto fields
  are only added if ext_tables.sql does not define a column or index.
  This makes the patch fully backwards compatible.
* No deprecation for obsolete field definitions in ext_tables.sql
  is logged.
* Many core fields are aligned to a central definition and slightly
  change. For instance "uid" is now always an unsigned int.
* Reduce all core's ext_tables.sql files as well as the functional
  testing related ext_tables.sql files down to the business fields
* A relatively huge series of test adaptions: Especially the
  ext:impexp related functionals now create dumps with differently
  sorted fields - This is no problem during import.
* Field t3_origuid of sys_file_reference has never been registered
  in TCA as ['ctrl']['origUid'], is thus unused and removed as obsolete.
* The extension manager no longer applies possible destructive changes,
  it only adds missing columns and tables when loading / updating
  extensions. It however considers *all* ext_tables.sql files, not only
  the one the extension in question provides. See the important .rst
  file for details.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 59

Show 39 more files