Review main Merged

57159[TASK] Unify simulate user settings for Backend admins

Christian Kuhn CR +2 V +2 Hard +200 −135 updated 06/21/18, 11:16

Commit message

The "Simulate user" functionality of the "User settings"
module for backend admins is UX wise a distaster: This
functionality is hidden behind the settings of the currently
logged-in backend user in the toolbar, which then magically
allows to change foreign user settings.

A much better approach to administrate user settings of other
users is to fully switch to the target user using the
"Backend User" module.

Additionally, if an admin user changes specific user settings of
existing or new users over and over again (eg. backend language),
sane defaults should be configured via User TSconfig "setup."
instead.

The patch unifies this functionality by removing the additional
simulate backend user selector from user settings module.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5