Review main Merged

57195[BUGFIX] Fix comments in various places

Benni Mack CR +2 V +2 Easy +4 −4 updated 06/12/18, 11:13

Commit message

There are some places where phpdoc comments and return types are wrong,
(an IDE shows this ASAP to you if you open up the file).

The patch fixes the small glitches.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Oliver Klee +1
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Wouter Wolters +2
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1215

  1. Benni Mack uploaded patch set 1 06/12/18, 08:25

  2. TYPO3com voted on patch set 1 V -1 06/12/18, 08:25 Completed build in 07s on Tue, 12 Jun, 10:25 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24345

  3. Benni Mack uploaded patch set 2 06/12/18, 09:11

  4. Wouter Wolters voted on patch set 2 V +1 CR +1 06/12/18, 09:15

  5. TYPO3com voted on patch set 2 V +1 06/12/18, 09:22 Completed build in 10m 52s on Tue, 12 Jun, 11:22 AM Test Summary: 32673 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24350

  6. Oliver Klee voted on patch set 2 CR +1 06/12/18, 09:26

  7. Oliver Klee commented on patch set 2 06/12/18, 09:26

    Can we also have this for 8.7 and 7.6?
  8. Benni Mack commented on patch set 2 06/12/18, 09:29

    Reply

    definitively not for 7.6 as this is not a critical bugfix.
  9. Benni Mack updated the commit message in patch set 3 06/12/18, 09:29

  10. TYPO3com voted on patch set 3 V +1 06/12/18, 09:38 Completed build in 08m 42s on Tue, 12 Jun, 11:38 AM Test Summary: 32673 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24352

  11. Oliver Klee voted on patch set 3 CR +1 06/12/18, 09:38

  12. Tymoteusz Motylewski voted on patch set 3 V +1 CR +1 06/12/18, 10:12

  13. Wouter Wolters voted on patch set 3 V +2 CR +2 06/12/18, 11:11

  14. Wouter Wolters merged patch set 4 06/12/18, 11:11

  15. Wouter Wolters commented on patch set 4 06/12/18, 11:13

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 11d1500a4534d1058288c7b93f9efdf4946dddf3