Review main Merged

57209[TASK] Handle some sqlite details

Christian Kuhn CR +2 V +2 Normal +46 −15 updated 06/13/18, 16:15

Commit message

* Similar to postgresql, sqlite index names must be unique
  within the entire database. The patch adds a hash of the
  table name in front of indexes to make them unique.

* SELECT'ing rows from a table and UPDATE'ing them while the
  select query is still running is not safe in sqlite, single
  rows may appear over and over again in the select() result
  set. The patch switches a query combination to a fetchAll()
  on sqlite platform to prevent this.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3