Review main Merged

57246[TASK] Merge str_replace calls when applied to a variable sequentially

Wouter Wolters CR +2 V +2 Normal +16 −37 updated 06/18/18, 05:02

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Stefan Bürk +1
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Stefan Bürk +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 79

  1. Wouter Wolters uploaded patch set 1 06/17/18, 14:45

  2. TYPO3com voted on patch set 1 V -1 06/17/18, 14:45 Completed build in 10s on Sun, 17 Jun, 04:45 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24522

  3. Wouter Wolters uploaded patch set 2 06/17/18, 14:46

  4. TYPO3com voted on patch set 2 V +1 06/17/18, 14:55 Completed build in 09m 38s on Sun, 17 Jun, 04:55 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24523

  5. Susi Moog voted on patch set 2 CR +1 06/17/18, 15:07

  6. Susi Moog voted on patch set 2 V +1 06/17/18, 15:15

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 06/17/18, 15:45

  8. Benni Mack voted on patch set 2 V +2 CR +2 06/18/18, 05:02

  9. Benni Mack merged patch set 3 06/18/18, 05:02