Review TYPO3_8-7 Merged

57254[BUGFIX] Fix wrong strlen check in DoubleMetaPhoneUtility

Benni Mack CR +2 V +2 Easy +1 −1 updated 06/18/18, 04:57

Commit message

while (strlen($this->primary) < 4 || strlen($this->secondary < 4)) {

should be

while (strlen($this->primary) < 4 || strlen($this->secondary) < 4) {

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 06/18/18, 04:33

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 06/18/18, 04:43 Completed build in 10m 01s on Mon, 18 Jun, 06:43 AM Test Summary: 58374 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2571

  3. Benni Mack voted on patch set 1 V +2 CR +2 06/18/18, 04:57

  4. Benni Mack merged patch set 2 06/18/18, 04:57