Review main Merged

57265[BUGFIX] Only query default language PIDs in suggest wizard

Benni Mack CR +2 V +2 Easy +2 −1 updated 06/21/18, 09:24

Commit message

Due to the removal of "pages_language_overlay", the page IDs for
FormEngine's suggest wizard contains page IDs of all languages, however
it is defined that the "pid" field is only limited to the default language.

Adding a check for `sys_language_uid=0` ensures that the pid IN
query is much smaller than before.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2
    • Nicole Hummel +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Benni Mack uploaded patch set 1 06/18/18, 17:25

  2. Wouter Wolters voted on patch set 1 CR +1 06/18/18, 17:27

  3. TYPO3com voted on patch set 1 V +1 06/18/18, 17:34 Completed build in 08m 44s on Mon, 18 Jun, 07:34 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24553

  4. Georg Ringer commented on patch set 1 06/18/18, 18:23

    SuggestWizardDefaultReceiver.php:313

    shouldn'T there also be -1 included?
  5. Benni Mack commented on patch set 1 06/19/18, 08:21

    @Georg, this is a "pidList" option. If you refer to "include -1" then we're talking about Workspaces, which is sorted out by the RestrictionContainer already. if you're talking about "sys_language_uid=-1" option, then you need to know that it's not possible to have "pages" records with a "-1" value.
  6. Georg Ringer voted on patch set 1 V +1 CR +1 06/19/18, 16:50

  7. Nicole Hummel voted on patch set 1 V +2 CR +2 06/21/18, 09:24

  8. Nicole Hummel merged patch set 2 06/21/18, 09:24