Review main Merged

57270[TASK] Add notes field for table pages

Georg Ringer CR +2 V +2 Easy +25 −1 updated 06/21/18, 13:22

Commit message

The table pages should have the notes field as well.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Mathias Brodala +1
    • Nicole Hummel +1
  • Verified V +2
    • Jigal van Hemert +2
    • Mathias Brodala +1
    • Nicole Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1113

  1. Georg Ringer uploaded patch set 1 06/20/18, 07:51

  2. Mathias Brodala voted on patch set 1 CR +1 06/20/18, 07:55

  3. TYPO3com voted on patch set 1 V +1 06/20/18, 07:59 Completed build in 08m 03s on Wed, 20 Jun, 09:59 AM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24556

  4. Tymoteusz Motylewski commented on patch set 1 06/20/18, 10:10

    Let's call this a feature please :)
  5. Nicole Hummel commented on patch set 1 CR -1 06/21/18, 09:19

    ext_tables.sql:114

    IMHO this should go into \TYPO3\CMS\Core\Database\Schema\DefaultTcaSchema
  6. Mathias Brodala commented on patch set 1 CR -2 06/21/18, 09:24

    Will change the DefaultTcaSchema first.

    ext_tables.sql:114 Reply

    Good idea, I'll push a separate change.
  7. Mathias Brodala commented on patch set 2 06/21/18, 09:28

    Published edit on patch set 1.
  8. Mathias Brodala commented on patch set 2 CR 0 06/21/18, 09:29

    It's already in there.
  9. Nicole Hummel voted on patch set 2 V +1 CR +1 06/21/18, 09:36

  10. Mathias Brodala voted on patch set 2 V +1 CR +1 06/21/18, 09:40

  11. TYPO3com voted on patch set 2 V +1 06/21/18, 09:40 Completed build in 11m 31s on Thu, 21 Jun, 11:40 AM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24579

  12. Jigal van Hemert voted on patch set 2 V +2 CR +2 06/21/18, 13:22

  13. Jigal van Hemert merged patch set 3 06/21/18, 13:22