57299[BUGFIX] Add allow="autoplay; fullscreen" to YouTube/Vimeo iframes
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Presedo Roberto +1
- Sebastian Hofer +1
- Robert Vierke +1
-
Verified V +2
- Stefan Neufeind +2
- Sebastian Hofer +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 1722
-
Frans Saris uploaded patch set 1 06/22/18, 15:05
-
TYPO3com voted on patch set 1 V -1 06/22/18, 15:13 Completed build in 07m 22s on Fri, 22 Jun, 05:13 PM Test Summary: 1 of 32960 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24623
-
Stefan Neufeind commented on patch set 1 V +1 CR +1 06/22/18, 15:24
worked for me to start Chrome 69 with an empty profile that had no interactions with youtube.com yet: $ google-chrome --profile-directory=something -
TYPO3com voted on patch set 1 V +1 06/22/18, 15:25 Completed build in 27m 25s on Fri, 22 Jun, 05:25 PM Test Summary: 32711 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24623
-
Frans Saris commented on patch set 1 06/22/18, 15:36
Don't merge this yet, keep it as easy to test for the t3dd coding night ;) -
Mathias Brodala updated the commit message in patch set 2 06/22/18, 17:59
-
TYPO3com voted on patch set 2 V +1 06/22/18, 18:07 Completed build in 08m 03s on Fri, 22 Jun, 08:07 PM Test Summary: 32711 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24642
-
Stefan Neufeind commented on patch set 2 V +1 CR +1 06/22/18, 18:23
reapplying vote -
Stefan Neufeind uploaded patch set 3 06/22/18, 18:45
-
Stefan Neufeind commented on patch set 3 06/22/18, 18:45
resolved merge-conflict in YouTubeRendererTests -
TYPO3com voted on patch set 3 V +1 06/22/18, 18:53 Completed build in 08m 36s on Fri, 22 Jun, 08:53 PM Test Summary: 32717 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24649
-
Presedo Roberto voted on patch set 3 V +1 CR +1 06/22/18, 20:26
-
Stefan Neufeind commented on patch set 3 06/22/18, 20:48
and "fullscreen" !!! -
Igor Prokhorov voted on patch set 3 V +1 CR +1 06/22/18, 20:55
-
Sebastian Hofer uploaded patch set 4 06/22/18, 21:19
-
Sebastian Hofer voted on patch set 4 V +1 CR +1 06/22/18, 21:20
-
Robert Vierke voted on patch set 4 CR +1 06/22/18, 21:30
-
TYPO3com voted on patch set 4 V +1 06/22/18, 21:31 Completed build in 11m 25s on Fri, 22 Jun, 11:31 PM Test Summary: 32717 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24689
-
Stefan Neufeind voted on patch set 4 V +2 CR +2 06/22/18, 21:41
-
Stefan Neufeind merged patch set 5 06/22/18, 21:41
-
anonymized-54557 voted on patch set 4 V +1 CR +1 06/22/18, 21:44
-
Presedo Roberto voted on patch set 5 CR +1 06/22/18, 21:58