Review main Merged

57299[BUGFIX] Add allow="autoplay; fullscreen" to YouTube/Vimeo iframes

Frans Saris CR +2 V +2 Normal +104 −36 updated 06/22/18, 21:58

Commit message

With the new chrome auto play policies we need to add a additional allow
attribute to the iframe to support autoplay.

https://developers.google.com/web/updates/2017/09/autoplay-policy-changes

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Presedo Roberto +1
    • Sebastian Hofer +1
    • Robert Vierke +1
  • Verified V +2
    • Stefan Neufeind +2
    • Sebastian Hofer +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1722

  1. Frans Saris uploaded patch set 1 06/22/18, 15:05

  2. TYPO3com voted on patch set 1 V -1 06/22/18, 15:13 Completed build in 07m 22s on Fri, 22 Jun, 05:13 PM Test Summary: 1 of 32960 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24623

  3. Stefan Neufeind commented on patch set 1 V +1 CR +1 06/22/18, 15:24

    worked for me to start Chrome 69 with an empty profile that had no interactions with youtube.com yet: $ google-chrome --profile-directory=something
  4. TYPO3com voted on patch set 1 V +1 06/22/18, 15:25 Completed build in 27m 25s on Fri, 22 Jun, 05:25 PM Test Summary: 32711 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24623

  5. Frans Saris commented on patch set 1 06/22/18, 15:36

    Don't merge this yet, keep it as easy to test for the t3dd coding night ;)
  6. Mathias Brodala updated the commit message in patch set 2 06/22/18, 17:59

  7. TYPO3com voted on patch set 2 V +1 06/22/18, 18:07 Completed build in 08m 03s on Fri, 22 Jun, 08:07 PM Test Summary: 32711 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24642

  8. Stefan Neufeind commented on patch set 2 V +1 CR +1 06/22/18, 18:23

    reapplying vote
  9. Stefan Neufeind uploaded patch set 3 06/22/18, 18:45

  10. Stefan Neufeind commented on patch set 3 06/22/18, 18:45

    resolved merge-conflict in YouTubeRendererTests
  11. TYPO3com voted on patch set 3 V +1 06/22/18, 18:53 Completed build in 08m 36s on Fri, 22 Jun, 08:53 PM Test Summary: 32717 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24649

  12. Presedo Roberto voted on patch set 3 V +1 CR +1 06/22/18, 20:26

  13. Stefan Neufeind commented on patch set 3 06/22/18, 20:48

    and "fullscreen" !!!
  14. Igor Prokhorov voted on patch set 3 V +1 CR +1 06/22/18, 20:55

  15. Sebastian Hofer uploaded patch set 4 06/22/18, 21:19

  16. Sebastian Hofer voted on patch set 4 V +1 CR +1 06/22/18, 21:20

  17. Robert Vierke voted on patch set 4 CR +1 06/22/18, 21:30

  18. TYPO3com voted on patch set 4 V +1 06/22/18, 21:31 Completed build in 11m 25s on Fri, 22 Jun, 11:31 PM Test Summary: 32717 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24689

  19. Stefan Neufeind voted on patch set 4 V +2 CR +2 06/22/18, 21:41

  20. Stefan Neufeind merged patch set 5 06/22/18, 21:41

  21. anonymized-54557 voted on patch set 4 V +1 CR +1 06/22/18, 21:44

  22. Presedo Roberto voted on patch set 5 CR +1 06/22/18, 21:58