Review main Merged

57306[TASK] Only import extensions from 2015+ into EM

Benni Mack CR +2 V +2 Easy +43 −1 updated 06/27/18, 08:41

Commit message

As proposed here https://decisions.typo3.org/t/reduce-size-of-extension-manager-db-table/329/
the EM only imports entries into the database from
TER that are uploaded from 2015-11-10 on, reducing
the database table size by 2/3.

As long as extensions.xml from TER does not
restrict this (e.g. by version) this reduces
import time when updating the extension list
and search handling within the Extension Manager.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Josef Glatz +1
    • Georg Ringer +1
    • Torben Hansen +1
  • Verified V +2
    • Wouter Wolters +2
    • Josef Glatz +1
    • Georg Ringer +1
    • Torben Hansen +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1519

  1. Benni Mack uploaded patch set 1 06/22/18, 19:08

  2. TYPO3com voted on patch set 1 V +1 06/22/18, 19:18 Completed build in 09m 35s on Fri, 22 Jun, 09:18 PM Test Summary: 32705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24657

  3. Benni Mack uploaded patch set 2 06/26/18, 17:33

  4. TYPO3com voted on patch set 2 V -1 06/26/18, 17:33 Completed build in 06s on Tue, 26 Jun, 07:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24881

  5. Benni Mack uploaded patch set 3 06/26/18, 19:29

  6. TYPO3com voted on patch set 3 V +1 06/26/18, 19:39 Completed build in 09m 55s on Tue, 26 Jun, 09:39 PM Test Summary: 32729 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24887

  7. Wouter Wolters voted on patch set 3 CR +1 06/26/18, 19:45

  8. Jörg Bösche voted on patch set 3 CR +1 06/26/18, 20:55

  9. Torben Hansen voted on patch set 3 V +1 CR +1 06/27/18, 05:35

  10. Georg Ringer commented on patch set 3 V +1 CR -1 06/27/18, 05:44

    Important-85393-ExtensionManagerOnlyImportsExtensionsCompatibleWithTYPO3V7LTSOrHigher.rst:13

    what I miss is why we do this. because we reduce the size of default DB dramatically, regarding this table ~66%
  11. Benni Mack commented on patch set 3 06/27/18, 05:48

    Important-85393-ExtensionManagerOnlyImportsExtensionsCompatibleWithTYPO3V7LTSOrHigher.rst:13 Reply

    but you did read the next paragraph?
  12. Josef Glatz voted on patch set 3 V +1 CR +1 06/27/18, 06:14

  13. Benni Mack commented on patch set 4 06/27/18, 07:48

    Published edit on patch set 3.
  14. Georg Ringer voted on patch set 4 V +1 CR +1 06/27/18, 07:49

  15. Torben Hansen voted on patch set 4 V +1 CR +1 06/27/18, 07:54

  16. TYPO3com voted on patch set 4 V +1 06/27/18, 07:57 Completed build in 08m 28s on Wed, 27 Jun, 09:57 AM Test Summary: 32750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24911

  17. Josef Glatz voted on patch set 4 V +1 CR +1 06/27/18, 08:26

  18. Wouter Wolters voted on patch set 4 V +2 CR +2 06/27/18, 08:41

  19. Wouter Wolters merged patch set 5 06/27/18, 08:41