57415[TASK] Reduce logic in render methods of YouTube and Vimeo Renderer
Commit message
Review
-
Code review CR +2
- Frans Saris +2
- Daniel Goerz +1
-
Verified V +2
- Frans Saris +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1114
-
Stefan Neufeind uploaded patch set 1 06/29/18, 06:55
-
TYPO3com voted on patch set 1 V -1 06/29/18, 06:56 Completed build in 06s on Fri, 29 Jun, 08:56 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2637
-
Stefan Neufeind uploaded patch set 2 06/29/18, 06:57
-
Stefan Neufeind commented on patch set 2 06/29/18, 06:59
Hand-picked from master. Please check! -
TYPO3com voted on patch set 2 V +1 06/29/18, 07:09 Completed build in 11m 40s on Fri, 29 Jun, 09:09 AM Test Summary: 58398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2638
-
Daniel Goerz voted on patch set 2 V +1 CR +1 06/29/18, 08:08
-
Daniel Goerz commented on patch set 2 06/29/18, 08:09
Maybe merge the backport of https://review.typo3.org/#/c/57325/ first -
Daniel Goerz commented on patch set 2 V 0 CR 0 06/29/18, 08:12
> Maybe merge the backport of https://review.typo3.org/#/c/57325/ > first The changes of the linked patch are already included here, so either merge the linked patch first or abandon it as it is included here. -
Stefan Neufeind commented on patch set 2 CR -1 06/29/18, 08:20
I've submitted the backport in the other patch now and will redo this patch here. Thanks for the reminder. -
Stefan Neufeind uploaded patch set 3 06/29/18, 08:36
-
TYPO3com voted on patch set 3 V +1 06/29/18, 08:44 Completed build in 08m 17s on Fri, 29 Jun, 10:44 AM Test Summary: 58422 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2642
-
Daniel Goerz voted on patch set 3 V +1 CR +1 06/29/18, 08:46
-
Frans Saris voted on patch set 3 V +2 CR +2 06/30/18, 06:33
-
Frans Saris merged patch set 4 06/30/18, 06:33