57465[TASK] Use str_replace instead of strtr to improve readability and clarity purposes
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Anja Leichsenring +1
- Robert van Kammen +1
- Rudy Gnodde +1
-
Verified V +2
- Andreas Kienast +2
- Anja Leichsenring +1
- Rudy Gnodde +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Core/ClassLoadingInformationGenerator.php+1 −1
- typo3/sysext/core/Classes/Http/ServerRequestFactory.php+2 −2
- typo3/sysext/core/Resources/PHP/ClassMapGenerator.php+5 −2
- typo3/sysext/install/Classes/Controller/UpgradeController.php+11 −3
- typo3/sysext/install/Classes/UpgradeAnalysis/DocumentationFile.php+3 −3
Review log 79
-
Wouter Wolters uploaded patch set 1 07/04/18, 18:08
-
TYPO3com voted on patch set 1 V -1 07/04/18, 18:09 Completed build in 08s on Wed, 4 Jul, 08:09 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25089
-
Wouter Wolters uploaded patch set 2 07/04/18, 18:09
-
TYPO3com voted on patch set 2 V +1 07/04/18, 18:18 Completed build in 08m 10s on Wed, 4 Jul, 08:18 PM Test Summary: 32880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25090
-
Rudy Gnodde voted on patch set 2 V +1 CR +1 07/06/18, 15:42
-
Robert van Kammen voted on patch set 2 CR +1 07/06/18, 16:03
-
Anja Leichsenring voted on patch set 2 V +1 CR +1 07/06/18, 20:26
-
Andreas Kienast voted on patch set 2 V +2 CR +2 07/06/18, 20:28
-
Andreas Kienast merged patch set 3 07/06/18, 20:28