57591[TASK] Deprecate -1 in language-related calls of PageRepository
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Stefan Neufeind +1
- Daniel Gorges +1
- Andreas Kienast +1
- Mathias Brodala +1
-
Verified V +2
- Benni Mack +2
- Daniel Gorges +1
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1722
-
Benni Mack uploaded patch set 1 07/13/18, 18:55
-
TYPO3com voted on patch set 1 V +1 07/13/18, 19:05 Completed build in 10m 14s on Fri, 13 Jul, 09:05 PM Test Summary: 33336 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25392
-
Benni Mack uploaded patch set 2 07/13/18, 20:13
-
TYPO3com voted on patch set 2 V -1 07/13/18, 20:25 Completed build in 11m 53s on Fri, 13 Jul, 10:25 PM Test Summary: 1 of 33582 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25400
-
TYPO3com voted on patch set 2 V +1 07/13/18, 20:29 Completed build in 27m 21s on Fri, 13 Jul, 10:29 PM Test Summary: 33336 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25400
-
Tymoteusz Motylewski commented on patch set 2 07/15/18, 09:38
-
Mathias Brodala commented on patch set 3 07/16/18, 07:19
Published edit on patch set 2. -
Mathias Brodala voted on patch set 3 CR +1 07/16/18, 07:20
-
TYPO3com voted on patch set 3 V +1 07/16/18, 07:27 Completed build in 07m 54s on Mon, 16 Jul, 09:27 AM Test Summary: 33312 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25453
-
Jörg Bösche voted on patch set 3 CR +1 07/18/18, 06:31
-
Stefan Neufeind voted on patch set 3 CR +1 07/18/18, 08:51
-
Wouter Wolters commented on patch set 3 07/18/18, 19:18
Deprecation-85553-PageRepositoryLanguage-relatedMethodsUseNullAsDefaultValue.rst:12what does calling# mean here? Missing something? -
Stefan Neufeind commented on patch set 4 07/18/18, 22:21
Published edit on patch set 3. -
Stefan Neufeind commented on patch set 3 07/18/18, 22:21
Deprecation-85553-PageRepositoryLanguage-relatedMethodsUseNullAsDefaultValue.rst:12Replya leftover from changeset 2->3 where the paragraph was changed around. Can be removed. I'll take care. -
Stefan Neufeind voted on patch set 4 CR +1 07/18/18, 22:21
-
TYPO3com voted on patch set 4 V +1 07/18/18, 22:29 Completed build in 07m 58s on Thu, 19 Jul, 12:29 AM Test Summary: 33375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25538
-
Mathias Brodala voted on patch set 4 CR +1 07/19/18, 07:35
-
Andreas Kienast voted on patch set 4 V +1 CR +1 07/19/18, 08:01
-
Daniel Gorges voted on patch set 4 V +1 CR +1 07/19/18, 10:13
-
Benni Mack voted on patch set 4 V +2 CR +2 07/19/18, 10:16
-
Benni Mack merged patch set 5 07/19/18, 10:16
-
Benni Mack commented on patch set 5 07/19/18, 10:47
Deprecation-85553-PageRepositoryLanguage-relatedMethodsUseNullAsDefaultValue.rst:12typo - will fix.
PageRepository.php:490