Review main Merged

57592[TASK] Deprecate PageRepository->versioningWorkspaceId

Benni Mack CR +2 V +2 Normal +64 −24 updated 07/23/18, 18:32

Commit message

The property does not need to be accessed from the outside anymore,
and can be marked as protected/deprecated, as this information is all
stored within the given context of the page repository.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 79

  1. Benni Mack uploaded patch set 1 07/13/18, 18:56

  2. TYPO3com voted on patch set 1 V -1 07/13/18, 19:06 Completed build in 09m 42s on Fri, 13 Jul, 09:06 PM Test Summary: 9 of 33581 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25393

  3. Benni Mack uploaded patch set 2 07/13/18, 20:32

  4. Andreas Kienast voted on patch set 2 CR +1 07/13/18, 20:35

  5. TYPO3com voted on patch set 2 V +1 07/13/18, 20:39 Completed build in 06m 51s on Fri, 13 Jul, 10:39 PM Test Summary: 33336 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25403

  6. Andreas Kienast voted on patch set 2 V +1 07/23/18, 17:59

  7. Wouter Wolters voted on patch set 2 CR +1 07/23/18, 18:23

  8. Wouter Wolters voted on patch set 2 V +2 CR +2 07/23/18, 18:32

  9. Wouter Wolters merged patch set 3 07/23/18, 18:32