Review main Abandoned

57639[TASK] Make ContentObjectRenderer notice free (1/x)

Jan Helke CR 0 V 0 Easy +19 −18 updated 08/14/18, 22:53

Commit message

This is the first of a series of patches comming to make the
ContentObjectRenderer notice free. To keep this kind of patches
reviewable (both codewise and checking the impact), this patch
only fixes a couple of notices.

Hox to test:
* Open ContentObjectRendererTest.php
* Remove or disable the line 75
  "protected static $suppressNotices = true;"
* Run this file of unit tests exclusively.
* Write down the ammount of errors reported. Them are all caused
  by PHP notices.

* Cherry pick the patch.
* Open ContentObjectRendererTest.php
* Remove or disable the line 75
  "protected static $suppressNotices = true;"
* Run this file of unit tests exclusively.
* If the amount of errors decrease and no failure is reported, this
  patch can be considered as "working"

The upcoming patches will be based on this patch and reduce the number
of errors even further.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1