Review main Merged

57674[BUGFIX] Context User Aspect must deal with empty fe_user

Benni Mack CR +2 V +2 Easy +6 −6 updated 07/25/18, 16:03

Commit message

TSFE->fe_user is set to '' by default, but UserAspect
expects "null".

Extensions like solr set up their own TSFE object which
is fine, however they still access gr_list which is OK,
because it is deprecated. However, a deprecation
message must be thrown, and NOT a strict typing warning.

UserAspect expects either "null" or object of type
AbstractUserAuthentication, but TSFE delivers '' by
default.

Modifying '' would not be an option as this would be
(slightly but still) breaking.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2