Review main Merged

57685[TASK] Deprecate methods in PageRepository

Wouter Wolters CR +2 V +2 Normal +136 −3 updated 08/05/18, 10:16

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Joerg Kummer +1
    • Anja Leichsenring +1
    • Łukasz Uznański +1
  • Verified V +2
    • Wouter Wolters +2
    • Joerg Kummer +1
    • Anja Leichsenring +1
    • Łukasz Uznański +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 2532

Show 57 earlier messages
  1. Wouter Wolters uploaded patch set 1 07/25/18, 19:11

  2. TYPO3com voted on patch set 1 V +1 07/25/18, 19:19 Completed build in 08m 07s on Wed, 25 Jul, 09:19 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25771

  3. Benni Mack commented on patch set 1 07/26/18, 20:20

    PageRepository.php:1401

    must be 9.4
  4. Mathias Brodala commented on patch set 1 07/30/18, 08:13

    PageRepository.php:1401

    Also double "@" here.

    PageRepository.php:1854

    Shouldn't this be "protected" now?
  5. Wouter Wolters uploaded patch set 2 07/31/18, 17:54

  6. TYPO3com voted on patch set 2 V -1 07/31/18, 17:54 Completed build in 05s on Tue, 31 Jul, 07:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25940

  7. Wouter Wolters uploaded patch set 3 07/31/18, 17:59

  1. Wouter Wolters uploaded patch set 4 07/31/18, 18:04

  2. TYPO3com voted on patch set 3 V -1 07/31/18, 18:09 Completed build in 09m 10s on Tue, 31 Jul, 08:09 PM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25942

  3. TYPO3com voted on patch set 4 V -1 07/31/18, 18:11 Completed build in 06m 57s on Tue, 31 Jul, 08:11 PM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25943

  4. Wouter Wolters commented on patch set 5 07/31/18, 18:11

    Published edit on patch set 4.
  5. TYPO3com voted on patch set 5 V +1 07/31/18, 18:25 Completed build in 13m 06s on Tue, 31 Jul, 08:25 PM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25947

  6. Benni Mack commented on patch set 5 CR -1 08/01/18, 15:47

    Deprecation-85699-DeprecateMethodsInPageRepository.rst:13

    have been marked as internal, they won't be removed.

    PageRepository.php:71

    todo
  7. Wouter Wolters uploaded patch set 6 08/02/18, 17:18

  8. TYPO3com voted on patch set 6 V +1 08/02/18, 17:24 Completed build in 06m 34s on Thu, 2 Aug, 07:24 PM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26039

  9. Daniel Goerz commented on patch set 6 CR -1 08/03/18, 09:24

    PageRepository.php:1794

    RST says the methods getMovePlaceholder and movePlhOL() have been marked as internal. But that would be achieved with @internal. making the method protected is a breaking change.
  10. Daniel Goerz commented on patch set 6 CR 0 08/03/18, 09:27

    Ah sorry, forgot about the trait. All good ;)
  11. Daniel Goerz commented on patch set 6 08/03/18, 09:28

    PageRepository.php:1794 Reply

    Done
  12. Joerg Kummer commented on patch set 6 CR -1 08/04/18, 18:14

    PageRepository.php:73

    Methods movePlhOL() & getMovePlaceholder() has been changed from public to protected, and are not marked as deprecated. Here should methods getRecordsByField() & getFileReferences() described.
  13. Wouter Wolters commented on patch set 6 08/04/18, 18:36

    PageRepository.php:73 Reply

    That is not correct! The methods listed here are now marked as protected. This is the mechanism to deprecated them but still have them accesible to not be breaking. Please remove your -1
  14. Joerg Kummer wrote 08/04/18, 18:38

    Removed Code-Review-1 by Joerg Kummer <typo3@enobe.de>
  15. Joerg Kummer commented on patch set 6 08/04/18, 18:42

    Should then the both other methods getRecordsByField() & getFileReferences() also been listed there, which in real are marked as deprecated? I tried an example with extension-scanner, which doesn't told me that methods getRecordsByField() & getFileReferences() are deprecated in PageRepository class.
  16. Wouter Wolters commented on patch set 6 08/04/18, 18:46

    No they should not be in that list. That list only contains methods that are marked as protected. The extension scanner configuration for both other methods are added in this commit as well. Should be catched as deprecated by the extension scanner
  17. Joerg Kummer commented on patch set 6 08/04/18, 18:51

    I'll try again
  18. Anja Leichsenring voted on patch set 6 V +1 CR +1 08/05/18, 07:38

  19. Anja Leichsenring uploaded patch set 7 08/05/18, 08:09

  20. Anja Leichsenring voted on patch set 7 V +1 CR +1 08/05/18, 08:09

  21. TYPO3com voted on patch set 7 V +1 08/05/18, 08:18 Completed build in 09m 05s on Sun, 5 Aug, 10:18 AM Test Summary: 33654 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26176

  22. Joerg Kummer voted on patch set 7 V +1 CR +1 08/05/18, 08:22

  23. Łukasz Uznański voted on patch set 7 V +1 CR +1 08/05/18, 08:29

  24. Wouter Wolters voted on patch set 7 V +2 CR +2 08/05/18, 10:16

  25. Wouter Wolters merged patch set 8 08/05/18, 10:16