57689[TASK] Provide record's uid to the suggest wizard
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Mathias Schreiber +1
- Markus Klein +1
-
Verified V +2
- Jigal van Hemert +2
- Mathias Schreiber +1
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1214
-
Xavier Perseguers uploaded patch set 1 07/26/18, 10:22
-
TYPO3com voted on patch set 1 V +1 07/26/18, 10:30 Completed build in 08m 04s on Thu, 26 Jul, 12:30 PM Test Summary: 33488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25802
-
Wouter Wolters voted on patch set 1 CR +1 07/26/18, 12:14
-
Andreas Wolf voted on patch set 1 CR +2 07/26/18, 12:18
-
Markus Klein commented on patch set 1 07/26/18, 12:20
Does it make sense to even have that in v8 too? it's not really a feature nor is it breaking in any kind -
Wouter Wolters commented on patch set 1 07/26/18, 12:28
Fine with me -
Xavier Perseguers commented on patch set 1 07/26/18, 12:59
Would be great to have it in v8 as well. I backported it to v7, where $uid is in fact $row['uid'] because there we have access to the full row record but not in v9 anymore. Did not check with v8 if just like v7 or like v9 -
Xavier Perseguers updated the commit message in patch set 2 07/26/18, 13:47
-
Markus Klein commented on patch set 2 V +1 CR +1 07/26/18, 13:54
v8 seems to have same code -
TYPO3com voted on patch set 2 V +1 07/26/18, 13:55 Completed build in 08m 01s on Thu, 26 Jul, 03:55 PM Test Summary: 33488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25805
-
Mathias Schreiber voted on patch set 2 V +1 CR +1 07/26/18, 13:58
-
Jigal van Hemert commented on patch set 2 V +2 CR +2 07/26/18, 15:10
No effect currently. No functionality to be called a feature, so it can be backported imo. -
Jigal van Hemert merged patch set 3 07/26/18, 15:11
-
Jigal van Hemert commented on patch set 3 07/26/18, 15:11
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit acb890d21c3dac322e453510c86f45ccbc4ce673