Review main Merged

57821[TASK] Deprecate GeneralUtility::unQuoteFilenames

Wouter Wolters CR +2 V +2 Hard +251 −180 updated 08/09/18, 11:54

Commit message

Moves the method over to CommandUtility as that is the only usage
in the core.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 810

  1. Wouter Wolters uploaded patch set 1 08/05/18, 13:05

  2. TYPO3com voted on patch set 1 V +1 08/05/18, 13:12 Completed build in 06m 33s on Sun, 5 Aug, 03:12 PM Test Summary: 33655 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26201

  3. Łukasz Uznański voted on patch set 1 V +1 CR +1 08/05/18, 19:07

  4. Wouter Wolters uploaded patch set 2 08/08/18, 11:30

  5. TYPO3com voted on patch set 2 V +1 08/08/18, 11:38 Completed build in 07m 18s on Wed, 8 Aug, 01:38 PM Test Summary: 33676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26263

  6. Benni Mack commented on patch set 2 08/08/18, 20:10

    Can we move the unit tests to CommandUtility in some way?
  7. Wouter Wolters commented on patch set 2 08/08/18, 20:15

    Could be done, I dropped the second parameter of the function because that is not in use. I need to strip half of the unit test because of that
  8. Georg Ringer voted on patch set 2 V +1 CR +1 08/08/18, 20:33

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 08/09/18, 11:54

  10. Christian Kuhn merged patch set 3 08/09/18, 11:54