Review main Abandoned

57830Revert "[TASK] Remove IP address from details field of sys_log entry"

Oliver Hader CR 0 V 0 Easy +15 −16 updated 08/07/18, 19:01

Commit message

This reverts commit dfbd98738b4edb77502c09f1ad6951d36134dcd3.

The sys_log entry IP anonymization has several flaws which lead to this
revert of the initial change in master:
* REMOTE_ADDR is anonymized, REMOTE_HOST not
  (probably there are more occurrences and flaws not being considered)
* PHP method sprintf() is invoked with too many arguments, username
  information is out of bounds
* introduced in https://review.typo3.org/#/c/57313/

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5