Review main Merged

57834[BUGFIX] Remove double zip extension when downloading in EM

Wouter Wolters CR +2 V +2 Easy +2 −2 updated 08/20/18, 10:55

Commit message

The download as zip action outputs the zip file with double .zip
extension. Remove the second .zip from the header.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Wouter Wolters uploaded patch set 1 08/08/18, 11:50

  2. TYPO3com voted on patch set 1 V +1 08/08/18, 11:56 Completed build in 06m 10s on Wed, 8 Aug, 01:56 PM Test Summary: 33696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26264

  3. Markus Klein commented on patch set 1 08/08/18, 12:13

    FileHandlingUtility.php:513

    so if $downloadName is set via function parameter there must be a zip extension included now Is that the case with all usages?
  4. Wouter Wolters commented on patch set 1 08/08/18, 12:23

    FileHandlingUtility.php:513 Reply

    there is only one usage in the core, see downloadExtensionZipAction $this->fileHandlingUtility->sendZipFileToBrowserAndDelete($fileName);
  5. Markus Klein voted on patch set 1 V +1 CR +1 08/08/18, 12:27

  6. Christian Kuhn commented on patch set 1 08/09/18, 11:57

    FileHandlingUtility.php:516

    this die should vanish anyway, later. guess a deprecation of that method shouldn't be too far away.
  7. Christian Kuhn voted on patch set 1 V +2 CR +2 08/09/18, 11:59

  8. Christian Kuhn merged patch set 2 08/09/18, 11:59

  9. Christian Kuhn commented on patch set 2 08/09/18, 12:05

    no backport: issue does not exist in v8
  10. Oliver Hader commented on patch set 2 08/20/18, 10:55

    No back-port since the previous issue was not back-ported to v8: https://review.typo3.org/#/c/47169/