Review main Merged

57838[BUGFIX] Fix wrong changelog information for #82794

Daniel Siepmann CR +2 V +2 Easy +15 −14 updated 08/09/18, 11:21

Commit message

The introduced keyword is called pageNotFound and is available for the
existing keyword content_fallback.
"stop" and "fallback" were wrong.

* Fix wrong syntax to allow rendering of list.
* Add roles for syntax highlighting of TS.
* Add styling to inline configuration.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Daniel Siepmann uploaded patch set 1 08/09/18, 06:31

  2. TYPO3com voted on patch set 1 V +1 08/09/18, 06:39 Completed build in 07m 29s on Thu, 9 Aug, 08:39 AM Test Summary: 33696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26278

  3. Markus Klein voted on patch set 1 V +1 CR +1 08/09/18, 08:06

  4. Wouter Wolters voted on patch set 1 CR +1 08/09/18, 10:01

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 08/09/18, 11:20

  6. Christian Kuhn merged patch set 2 08/09/18, 11:20

  7. Christian Kuhn commented on patch set 2 08/09/18, 11:21

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit c3b3ba0f14031cacf4531b32318f8270042c641f