Review main Merged

57847[TASK] Refactor SaltFactory

Christian Kuhn CR +2 V +2 Hard +520 −207 updated 08/09/18, 18:39

Commit message

The patch deprecates static SaltFactory::getSaltingInstance()
and replaces it with the two new non-static methods.
The ->get() method returns a hash instance to check a given password
against a given hash, and ->getDefaultHashInstance() which returns
an instance of the configured default hash method to calculate
a hash for a new password.

The new methods are now strict, non-static and throw exceptions if
something goes wrong. This simplifies mocking in tests and sanitizes
password hash handling in the core.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 20