Review main Merged

57851[FEATURE] Use symfony/routing for Site Resolving

Benni Mack CR +2 V +2 Hard +654 −222 updated 08/11/18, 18:29

Commit message

Use symfony/router 4.1 for resolving a site based on the
current request.

This actually removes some simple resolving built previously
by myself, which was stupid code to detect a site base.

With the symfony/routing component, it is now possible to
have site base prefixes without a scheme (just the domain)
and allow to handle both prefixes. It is also possible to
just add "/site1" and "/site2" as base for domains as
well, allowing to listen to any incoming domain.

As this Routing component will be used for further
page-based routing, the introduced symfony-specific
code might change and encapsulated in other places.

With this patch we now require symfony 4.1 components
or higher, as symfony/routing became fast with 4.1,
and symfony/routing 4.1 is incompatible with various 3.x
components we use. Composer-based installations might
not be able to upgrade, if they have a strong
dependency on a lower symfony version.

The composer command used:
    composer req symfony/console:^4.1 symfony/expression-language:^4.1 \
    symfony/finder:^4.1 symfony/routing:^4.1 symfony/yaml:^4.1 \
    --update-with-dependencies

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 12