Review main Merged

57858[TASK] Deprecate second argument of PageRenderer::addInlineLanguageLabelArray

Wouter Wolters CR +2 V +2 Normal +65 −11 updated 08/11/18, 18:19

Commit message

Calling `PageRenderer::addInlineLanguageLabelArray` with a second
parameter set to "true" is deprecated. Use the LanguageService directly
when defining your labels.

Review

  • Code review CR +2
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 911

  1. Wouter Wolters uploaded patch set 1 08/10/18, 12:38

  2. Benni Mack voted on patch set 1 CR +1 08/10/18, 12:42

  3. TYPO3com voted on patch set 1 V +1 08/10/18, 12:46 Completed build in 08m 07s on Fri, 10 Aug, 02:46 PM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26359

  4. Benni Mack voted on patch set 1 V +1 08/10/18, 23:46

  5. Christian Kuhn commented on patch set 1 CR -1 08/11/18, 18:08

    will rebase
  6. Christian Kuhn uploaded patch set 2 08/11/18, 18:09

  7. Christian Kuhn commented on patch set 2 08/11/18, 18:09

    rebased
  8. Christian Kuhn voted on patch set 2 V +1 CR +1 08/11/18, 18:13

  9. TYPO3com voted on patch set 2 V +1 08/11/18, 18:19 Completed build in 09m 35s on Sat, 11 Aug, 08:19 PM Test Summary: 34599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26445

  10. Benni Mack voted on patch set 2 V +2 CR +2 08/11/18, 18:19

  11. Benni Mack merged patch set 3 08/11/18, 18:19