Review main Merged

57869[TASK] Correctly initialize environment for DataHandler in tests

Oliver Hader CR +2 V +2 Normal +47 −23 updated 08/11/18, 09:38

Commit message

Since importing data scenarios in tests relies on DataHandler, it is
required to correctly initialize $GLOBALS['LANG'] as well. Since not
all tests were failing, this probably points out side effects during
test execution in terms of reusing globals settings of other tests.

Besides that, a misbehavior in typo3/testing-framework lead to the
situation that not all entities have been created - which would have
triggered DataHandler log entries that rely on previously mentioned
$GLOBALS['LANG'] instance.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 7