Review main Merged

57894[BUGFIX] Make functional frontend tests work again

Helmut Hummel CR +2 V +2 Easy +10 −18 updated 08/16/18, 12:39

Commit message

On systems that populate $_ENV['_'] with the path
to the PHP binary, frontend functional tests fail.

This is due to the fact that TYPO3 tries to determine paths 
based on a cli environment, while we in fact emulate
a frontend (HTTP server) environment in this scenario.

This can be fixed with checking for the "magic"
context "Testing/Frontend", which was added beforehand
already in a different place.

At the same time we simplify the code used to make
functional tests work without process isolation, to
make it better communicate the intention and also
make it more robust.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 1