Review main Merged

57909[TASK] Deprecate GeneralUtility::clientInfo()

Benni Mack CR +2 V +2 Normal +77 −2 updated 08/15/18, 17:34

Commit message

The functionality for parsing the HTTP_USER_AGENT server variable is only
used in one place within TYPO3 core and can be substituted directly with
the proper HTTP_USER_AGENT string.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 68

  1. Benni Mack uploaded patch set 1 08/15/18, 09:10

  2. TYPO3com voted on patch set 1 V +1 08/15/18, 09:18 Completed build in 07m 11s on Wed, 15 Aug, 11:18 AM Test Summary: 34830 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26608

  3. Benni Mack uploaded patch set 2 08/15/18, 09:22

  4. TYPO3com voted on patch set 2 V +1 08/15/18, 09:30 Completed build in 07m 25s on Wed, 15 Aug, 11:30 AM Test Summary: 34836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26609

  5. Wouter Wolters voted on patch set 2 CR +1 08/15/18, 09:50

  6. Wouter Wolters voted on patch set 2 V +1 08/15/18, 09:54

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 08/15/18, 17:34

  8. Christian Kuhn merged patch set 3 08/15/18, 17:34