Review main Merged

57937[BUGFIX] Fix calling getInstance() twice to get ResourceFactory

Wouter Wolters CR +2 V +2 Easy +3 −3 updated 08/16/18, 21:20

Commit message

In the class MetaInformation the ResourceFactory instance is fetched
twice instead of once. Remove one call that is too much.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Wouter Wolters uploaded patch set 1 08/16/18, 20:57

  2. TYPO3com voted on patch set 1 V +1 08/16/18, 21:07 Completed build in 09m 59s on Thu, 16 Aug, 11:07 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26690

  3. Markus Klein voted on patch set 1 V +1 CR +1 08/16/18, 21:07

  4. Wouter Wolters commented on patch set 1 CR -1 08/16/18, 21:09

    there is another one
  5. Wouter Wolters uploaded patch set 2 08/16/18, 21:09

  6. Markus Klein voted on patch set 2 V +1 CR +1 08/16/18, 21:11

  7. TYPO3com voted on patch set 2 V +1 08/16/18, 21:17 Completed build in 07m 16s on Thu, 16 Aug, 11:17 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26693

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 08/16/18, 21:20

  9. Christian Kuhn merged patch set 3 08/16/18, 21:20