Review main Merged

57950[BUGFIX] Correct extension scanner matcher definitions

Christian Kuhn CR +2 V +2 Easy +13 −1 updated 08/17/18, 13:27

Commit message

Add a couple of missing numberOfMandatoryArguments lines
to the MethodCallMatcher definitions to fix the extension
scanner that validates these files at runtime.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Christian Kuhn uploaded patch set 1 08/17/18, 12:45

  2. Christian Kuhn commented on patch set 1 08/17/18, 12:46

    test: extension scanner throws tons of 'something wrong' red bubbles without patch ...
  3. Wouter Wolters commented on patch set 1 08/17/18, 12:51

    MethodCallMatcher.php:2890

    0
  4. Wouter Wolters commented on patch set 2 08/17/18, 12:51

    Published edit on patch set 1.
  5. Wouter Wolters voted on patch set 2 V +1 CR +1 08/17/18, 12:52

  6. TYPO3com voted on patch set 1 V +1 08/17/18, 12:55 Completed build in 09m 32s on Fri, 17 Aug, 02:55 PM Test Summary: 34879 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26738

  7. TYPO3com voted on patch set 2 V +1 08/17/18, 13:03 Completed build in 09m 29s on Fri, 17 Aug, 03:03 PM Test Summary: 34879 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26741

  8. Benni Mack voted on patch set 2 V +2 CR +2 08/17/18, 13:27

  9. Benni Mack merged patch set 3 08/17/18, 13:27