Review main Abandoned

58012[TASK] Move Site Resolving before TSFE initialization in Frontend

Benni Mack CR 0 V 0 Normal +36 −32 updated 08/30/18, 13:24

Commit message

When a site is resolved and determined, this should happen before
TSFE gets initialized.

This removes the dependency that the SiteResolver has to re-set the
$id within TSFE, thus, effectively removing the dependency of
SiteResolver from TSFE itself.

So, the site resolving middleware is put right before
TypoScriptFrontendInitialization, having TSFE receiving the
resolved GET['id'] value directly.

Additionally, the following changes are done:
- PageRouter does not need FrontendRestrictionContainer, as there is
  only one slug available for a site available anyways, "hidden" /
  "starttime/endtime" and "fe_group" are handled within
  TSFE->determineId() within PageResolver middleware for the whole
  root line of the given Page ID.
- The check if the database is available is moved to the
  MaintenanceMode Middleware to allow to still go into the
  "unavailable" action of the page.

As a result, $request is always enriched with the site+language
when TSFE gets initialized which allows further optimizations.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5