58014[BUGFIX] Fix PSR-7 URI generation without scheme
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Oliver Hader +1
-
Verified V +2
- Helmut Hummel +2
- Oliver Hader +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1013
-
Benni Mack uploaded patch set 1 08/23/18, 21:14
-
TYPO3com voted on patch set 1 V +1 08/23/18, 21:24 Completed build in 09m 58s on Thu, 23 Aug, 11:24 PM Test Summary: 35292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26996
-
Wouter Wolters voted on patch set 1 CR +1 08/23/18, 21:32
-
Christian Kuhn commented on patch set 1 08/23/18, 22:26
ok for master, but i'm not fully sure about v8: do we really need the patch in v8? it's quite hard for me to understand the full impact/risk here. -
Benni Mack updated the commit message in patch set 2 08/24/18, 10:11
-
TYPO3com voted on patch set 2 V +1 08/24/18, 10:39 Completed build in 26m 28s on Fri, 24 Aug, 12:39 PM Test Summary: 35292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27016
-
Oliver Hader commented on patch set 2 CR -1 08/24/18, 13:39
UriTest.php:492Cast both to (string) -
Oliver Hader uploaded patch set 3 08/24/18, 13:43
-
Oliver Hader voted on patch set 3 V +1 CR +1 08/24/18, 13:43
-
TYPO3com voted on patch set 3 V +1 08/24/18, 13:52 Completed build in 09m 49s on Fri, 24 Aug, 03:52 PM Test Summary: 35292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27023
-
Benni Mack commented on patch set 3 08/24/18, 14:25
this fixes wrong Link Generation in Backend when a site has only www.domain.com as site base. -
Helmut Hummel voted on patch set 3 V +2 CR +2 08/24/18, 14:33
-
Helmut Hummel merged patch set 4 08/24/18, 14:33