Review main Merged

58025[TASK] Remove unused TimeTracker->fixContent() method argument

Benni Mack CR +2 V +2 Easy +4 −5 updated 08/25/18, 12:23

Commit message

The protected method TimeTracker->fixContent() has an argument $first
which is always set to "0", so the functionality can be removed.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
  • Verified V +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Benni Mack uploaded patch set 1 08/24/18, 15:22

  2. TYPO3com voted on patch set 1 V +1 08/24/18, 15:34 Completed build in 11m 37s on Fri, 24 Aug, 05:34 PM Test Summary: 35292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27030

  3. Wouter Wolters voted on patch set 1 V +1 CR +1 08/25/18, 11:51

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 08/25/18, 12:23

  5. Andreas Kienast merged patch set 2 08/25/18, 12:23