Review main Merged

58081[TASK] Extract _GP call from TSFE->initializeSearchWordData

Benni Mack CR +2 V +2 Normal +64 −6 updated 08/30/18, 12:04

Commit message

In order to centralize usages regarding global magic ($_GET/$_POST) within
TypoScriptFrontendController, the method initializeSearchWordData()
is renamed to something useful, and is now handed in the variable from
GeneralUtility::_GP() and also gets some unit tests, making this method
also notice-free, as a side-effect.

This pre-patch allows to inject something else (PSR-7 request) in the future
without ever touching this method.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 56

  1. Benni Mack uploaded patch set 1 08/30/18, 09:14

  2. TYPO3com voted on patch set 1 V +1 08/30/18, 09:23 Completed build in 08m 04s on Thu, 30 Aug, 11:23 AM Test Summary: 35334 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27287

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 08/30/18, 10:03

  4. Wouter Wolters voted on patch set 1 CR +1 08/30/18, 11:09

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 08/30/18, 12:04

  6. Christian Kuhn merged patch set 2 08/30/18, 12:04