Review main Merged

58083[TASK] Change visibility of TSFE properties and methods

Benni Mack CR +2 V +2 Normal +219 −14 updated 09/16/18, 21:47

Commit message

The following properties have changed their
visibility to be protected from public.

* pageAccessFailureHistory
* workspacePreview (not in use anymore)
* ADMCMD_preview_BEUSER_uid (not in use anymore)
* debug (not in use anymore)
* MP_defaults (not in use anymore outside of TSFE)
* loginAllowedInBranch (use checkIfLoginAllowedInBranch())

The following methods have changed their signature to be
protected, as their purpose is to be called from within
TypoScriptFrontendController.

- tempPageCacheContent()
- realPageCacheContent()
- setPageCacheContent()
- clearPageCacheContent_pidList()
- setSysLastChanged()
- contentStrReplace()

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 2027

Show 12 earlier messages
  1. Benni Mack uploaded patch set 1 08/30/18, 10:55

  2. TYPO3com voted on patch set 1 V +1 08/30/18, 11:04 Completed build in 08m 55s on Thu, 30 Aug, 01:04 PM Test Summary: 35319 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27294

  1. Benni Mack uploaded patch set 2 08/30/18, 21:24

  2. TYPO3com voted on patch set 2 V +1 08/30/18, 21:33 Completed build in 09m 31s on Thu, 30 Aug, 11:33 PM Test Summary: 35376 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27366

  3. Wouter Wolters uploaded patch set 3 09/01/18, 10:00

  4. Wouter Wolters updated the commit message in patch set 4 09/01/18, 10:00

  5. TYPO3com voted on patch set 3 V +1 09/01/18, 10:10 Completed build in 10m 03s on Sat, 1 Sep, 12:10 PM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27462

  6. TYPO3com voted on patch set 4 V +1 09/01/18, 10:12 Completed build in 12m 23s on Sat, 1 Sep, 12:12 PM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27463

  7. Wouter Wolters voted on patch set 4 V +1 CR +1 09/01/18, 10:17

  8. Christian Kuhn commented on patch set 4 CR -1 09/01/18, 12:25

    TypoScriptFrontendController.php:101

    this method is not called at all. fully deprecate instead?

    TypoScriptFrontendController.php:104

    this one is called ~3441 as $temp_copy_TSFE->getPageAndRootlineWithDomain()

    TypoScriptFrontendController.php:473

    this is used in sysext/frontend/Classes/Http/RequestHandler.php ~719: $controller->JSCode
  9. Benni Mack commented on patch set 4 09/03/18, 09:07

    TypoScriptFrontendController.php:101 Reply

    Hmm, people still use this method in extensions. Maybe we should document that they should use the pagecache / CF directly then. After that => fully deprecate.

    TypoScriptFrontendController.php:104 Reply

    AFAIK you can call/access protected methods/members within the clone process. We do this with PSR-7.

    TypoScriptFrontendController.php:473 Reply

    corret. let's just mark it as @internal (I have a separate patch for that kindof stuff)
  10. Benni Mack commented on patch set 4 CR -2 09/07/18, 22:11

    will continue working on that in the next weeks.
  11. Benni Mack uploaded patch set 5 09/14/18, 09:49

  12. Benni Mack voted on patch set 5 CR 0 09/14/18, 09:49

  13. TYPO3com voted on patch set 5 V +1 09/14/18, 10:00 Completed build in 11m 33s on Fri, 14 Sep, 12:00 PM Test Summary: 35914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28079

  14. Frank Nägler voted on patch set 5 V +1 CR +1 09/14/18, 20:09

  15. Christian Kuhn commented on patch set 5 CR -1 09/15/18, 14:58

    TypoScriptFrontendController.php:1889

    still used externally in preparePageContentGeneration() ~3468: $temp_copy_TSFE->getPageAndRootlineWithDomain()
  16. Christian Kuhn uploaded patch set 6 09/15/18, 15:01

  17. Christian Kuhn commented on patch set 6 V +1 CR +1 09/15/18, 15:01

    removed setting getPageAndRootlineWithDomain() to protected.
  18. TYPO3com voted on patch set 6 V +1 09/15/18, 15:10 Completed build in 09m 04s on Sat, 15 Sep, 05:10 PM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28128

  19. Andreas Kienast commented on patch set 6 CR -1 09/16/18, 20:14

    TypoScriptFrontendController.php:474 Unresolved

    I guess this is wrong: It's neither mentioned in ReST not handled in the deprecation down below. Also, this property is still used in RequestHandler.php and PageGenerator.php
  20. Andreas Kienast commented on patch set 6 09/16/18, 20:15

    TypoScriptFrontendController.php:275 Unresolved

    Must be protected
  21. Andreas Kienast uploaded patch set 7 09/16/18, 20:17

  22. Andreas Kienast voted on patch set 7 V +1 CR +1 09/16/18, 20:18

  23. TYPO3com voted on patch set 7 V +1 09/16/18, 20:27 Completed build in 09m 41s on Sun, 16 Sep, 10:27 PM Test Summary: 35932 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28203

  24. Christian Kuhn voted on patch set 7 V +2 CR +2 09/16/18, 21:47

  25. Christian Kuhn merged patch set 8 09/16/18, 21:47