Review main Merged

58157[BUGFIX] Create proper FE links in Web->View module

Christian Kuhn CR +2 V +2 Easy +25 −22 updated 09/03/18, 20:41

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
  • Verified V +2
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1218

  1. Christian Kuhn uploaded patch set 1 09/03/18, 19:40

  2. TYPO3com voted on patch set 1 V -1 09/03/18, 19:42 Completed build in 18s on Mon, 3 Sep, 09:42 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27705

  3. Wouter Wolters commented on patch set 2 09/03/18, 19:47

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V -1 09/03/18, 19:47 Completed build in 13s on Mon, 3 Sep, 09:47 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27707

  5. Wouter Wolters commented on patch set 3 09/03/18, 19:48

    Published edit on patch set 2.
  6. Christian Kuhn rebased onto patch set 4 09/03/18, 19:48

  7. Christian Kuhn rebased onto patch set 5 09/03/18, 19:49

  8. Wouter Wolters commented on patch set 3 09/03/18, 19:49

    ViewModuleController.php:211

    mayeb rename this to $siteMatcher?
  9. TYPO3com voted on patch set 3 V +1 09/03/18, 19:59 Completed build in 10m 40s on Mon, 3 Sep, 09:59 PM Test Summary: 35965 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27708

  10. Anja Leichsenring commented on patch set 5 09/03/18, 20:02

    on it
  11. Anja Leichsenring uploaded patch set 6 09/03/18, 20:03

  12. TYPO3com voted on patch set 4 V +1 09/03/18, 20:04 Completed build in 15m 27s on Mon, 3 Sep, 10:04 PM Test Summary: 35965 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27709

  13. TYPO3com voted on patch set 5 V +1 09/03/18, 20:09 Completed build in 13m 57s on Mon, 3 Sep, 10:09 PM Test Summary: 35965 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27710

  14. Anja Leichsenring voted on patch set 6 V +1 CR +1 09/03/18, 20:23

  15. Wouter Wolters voted on patch set 6 CR +1 09/03/18, 20:25

  16. TYPO3com voted on patch set 6 V +1 09/03/18, 20:27 Completed build in 11m 26s on Mon, 3 Sep, 10:27 PM Test Summary: 35977 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27715

  17. Benni Mack voted on patch set 6 V +2 CR +2 09/03/18, 20:41

  18. Benni Mack merged patch set 7 09/03/18, 20:41