Review main Merged

58214[TASK] Protected methods in ReportController

Christian Kuhn CR +2 V +2 Normal +60 −8 updated 09/07/18, 17:05

Commit message

There are only two methods in the report controller, calling
them via call_user_function() does not make much sense.
The patch simplifies the dispatcher logic and sets the two
actions to protected.
Note this does not affect the extendability of the reports
module itself.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2