Review main Merged

58249[TASK] Deprecate BaseScriptClass and AbstractFunctionModule

Christian Kuhn CR +2 V +2 Normal +86 −0 updated 09/12/18, 18:12

Commit message

With latest refactorings, the good old backend module classes
BaseScriptClass (t3lib_SCbase) and AbstractFunctionModule
(t3lib_extobjbase) are finally unused.
These spaghetti classes have been a hindrance to refactor
modules that used them for a long time already due to their
hard to follow code flow, bad method namings, global variable
usages and having everything declared public.
It's time to get rid of them to unlock refactoring of controllers
and allow dropping of various global variables in v10.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4