Review main Merged

58251[BUGFIX] Catch non existing directories for import syntax

Georg Ringer CR +2 V +2 Easy +13 −9 updated 09/12/18, 06:54

Commit message

Catch exceptions for non existing directories which are imported using
the @import syntax for TypoScript and return those as warning in the
template module.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Benni Mack +1
  • Verified V +2
    • Wouter Wolters +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Georg Ringer uploaded patch set 1 09/11/18, 17:28

  2. Georg Ringer wrote 09/11/18, 17:28

    Assignee added: Benni Mack <benni@typo3.org>
  3. Georg Ringer wrote 09/11/18, 17:28

    Assignee changed from: Benni Mack <benni@typo3.org> to: Anja Leichsenring <aleichsenring@ab-softlab.de>
  4. Georg Ringer wrote 09/11/18, 17:29

    Assignee deleted: Anja Leichsenring <aleichsenring@ab-softlab.de>
  5. TYPO3com voted on patch set 1 V +1 09/11/18, 17:36 Completed build in 08m 13s on Tue, 11 Sep, 07:36 PM Test Summary: 35869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27973

  6. Wouter Wolters voted on patch set 1 CR +1 09/11/18, 17:53

  7. Benni Mack voted on patch set 1 V +1 CR +1 09/12/18, 06:04

  8. Wouter Wolters voted on patch set 1 V +2 CR +2 09/12/18, 06:54

  9. Wouter Wolters merged patch set 2 09/12/18, 06:54