58274[TASK] Make hreflang generator use PSR7 interface
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Markus Klein +1
- Richard Haeser +1
-
Verified V +2
- Benni Mack +2
- Richard Haeser +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1824
-
Richard Haeser uploaded patch set 1 09/14/18, 09:31
-
Richard Haeser updated the commit message in patch set 2 09/14/18, 09:34
-
Benni Mack commented on patch set 2 09/14/18, 09:35
-
Richard Haeser uploaded patch set 3 09/14/18, 09:36
-
TYPO3com voted on patch set 1 V +1 09/14/18, 09:40 Completed build in 08m 42s on Fri, 14 Sep, 11:40 AM Test Summary: 35914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28076
-
TYPO3com voted on patch set 2 V +1 09/14/18, 09:45 Completed build in 10m 48s on Fri, 14 Sep, 11:45 AM Test Summary: 35914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28077
-
TYPO3com voted on patch set 3 V +1 09/14/18, 09:47 Completed build in 09m 47s on Fri, 14 Sep, 11:47 AM Test Summary: 35914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28078
-
Richard Haeser uploaded patch set 4 09/14/18, 12:39
-
Benni Mack commented on patch set 4 09/14/18, 12:42
HrefLangGenerator.php:80should not be public -
TYPO3com voted on patch set 4 V +1 09/14/18, 12:48 Completed build in 08m 28s on Fri, 14 Sep, 02:48 PM Test Summary: 35932 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28092
-
Richard Haeser uploaded patch set 5 09/14/18, 12:53
-
TYPO3com voted on patch set 5 V +1 09/14/18, 13:04 Completed build in 10m 52s on Fri, 14 Sep, 03:04 PM Test Summary: 35932 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28094
-
Sascha Egerer commented on patch set 5 09/14/18, 13:14
HrefLangGenerator.php:82Why new and not GeneralUtility::makeInstance()? -
Andreas Kienast commented on patch set 5 09/14/18, 14:02
HrefLangGenerator.php:82ReplyBecause that's low level API which is not meant to be XCLASSable. -
Sascha Egerer commented on patch set 5 09/14/18, 14:08
HrefLangGenerator.php:82ReplyAh yeah. ok. Uri is low level. -
Sascha Egerer voted on patch set 5 CR +1 09/14/18, 14:08
-
Georg Ringer voted on patch set 5 V +1 CR +1 09/14/18, 18:37
-
Markus Klein commented on patch set 5 09/15/18, 12:30
an absolute -
Markus Klein updated the commit message in patch set 6 09/15/18, 12:32
-
Markus Klein voted on patch set 6 CR +1 09/15/18, 12:32
-
TYPO3com voted on patch set 6 V +1 09/15/18, 12:41 Completed build in 08m 59s on Sat, 15 Sep, 02:41 PM Test Summary: 35932 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28115
-
Richard Haeser voted on patch set 6 V +1 CR +1 09/16/18, 10:31
-
Benni Mack voted on patch set 6 V +2 CR +2 09/16/18, 19:49
-
Benni Mack merged patch set 7 09/16/18, 19:49
HreflangGenerator.php:63