Review main Merged

58285[BUGFIX] Fix fatal in SchedulerModuleController on some DB drivers

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 09/15/18, 17:02

Commit message

Some DB drivers like pdo_mysql and our postgres flavor return
values from DB always as string. Classes with enabled strict_types
then tend to fail if those values that should be integers but are
strings are fed to functions that accept integers only. The patch
fixes two places in SchedulerModuleController where a db value
is directly sent to date(), which needs an int as second argument.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1