Review main Merged

58288[TASK] Deprecate config.tx_extbase.objects and plugin.tx_%name%.objects

Benjamin Franzke CR +2 V +2 Normal +67 −6 updated 09/18/18, 07:09

Commit message

If we want to introduce a system wide container in v10,
the non deterministic behaviour of object (re)configurations
during runtime in extbase will be a problem.
Compiled containers like symfony DI do not allow runtime
reconfigurations.

Also the concept of per plugin overwrites is broken anyway,
and should therefore be dropped:
The "objects" configured through plugin.tx_%name%.objects
are are never reset, that means:
Plugin A might overwrite an object and plugin B will implictly use
that overriden class, despite not having configured that at all.
(depending on the fact whether plugin A is rendered before or not)

config.tx_extbase.object class overwrites can be replaced by XCLASSes.
If config.tx_extbase.object was/is used to conditionally overwrite
classes (through sys_template or conditions), these
occasions should be changed to XCLASSes as well. In that case the
conditional overwrite needs to be moved into the xclass itself.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5