Review main Merged

58290[TASK] Suppress mount point resolving if there are none

Christian Kuhn CR +2 V +2 Easy +3 −4 updated 09/18/18, 19:07

Commit message

BE admins without mountpoints set have value '0' in
$this->groupData['webmounts']. If this is checked additonally
to empty string, some 'where uid=0' database calls can be suppressed.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1316

  1. Christian Kuhn uploaded patch set 1 09/16/18, 08:06

  2. TYPO3com voted on patch set 1 V +1 09/16/18, 08:16 Completed build in 09m 41s on Sun, 16 Sep, 10:16 AM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28152

  3. Markus Klein updated the commit message in patch set 2 09/16/18, 08:29

  4. Markus Klein commented on patch set 2 09/16/18, 08:30

    BackendUserAuthentication.php:1434

    why not using empty()?
  5. Andreas Kienast commented on patch set 2 09/16/18, 08:31

    BackendUserAuthentication.php:1434 Reply

    IIRC empty('0') returns false
  6. TYPO3com voted on patch set 2 V +1 09/16/18, 08:37 Completed build in 07m 41s on Sun, 16 Sep, 10:37 AM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28155

  7. Wouter Wolters voted on patch set 2 CR +1 09/16/18, 10:12

  8. Markus Klein commented on patch set 2 09/16/18, 22:49

    BackendUserAuthentication.php:1434 Reply

    well, that's exactly the point: this is TRUE ;-) empty(false) = empty('') = empty(0) = empty([]) = empty('0') = true
  9. Christian Kuhn uploaded patch set 3 09/16/18, 23:01

  10. Christian Kuhn commented on patch set 2 09/16/18, 23:01

    BackendUserAuthentication.php:1434 Reply

    simplified that, now.
  11. TYPO3com voted on patch set 3 V +1 09/16/18, 23:11 Completed build in 09m 57s on Mon, 17 Sep, 01:11 AM Test Summary: 35932 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28206

  12. Susi Moog voted on patch set 3 CR +1 09/18/18, 11:02

  13. Andreas Kienast voted on patch set 3 CR +1 09/18/18, 18:50

  14. Andreas Kienast voted on patch set 3 V +1 09/18/18, 19:06

  15. Georg Ringer voted on patch set 3 V +2 CR +2 09/18/18, 19:07

  16. Georg Ringer merged patch set 4 09/18/18, 19:07