Review main Abandoned

58298[WIP][BUGFIX] Ensure cli tool is always working

Helmut Hummel CR 0 V 0 Hard +328 −102 updated 10/27/18, 15:49

Commit message

The TYPO3 cli tool is now guaranteed to run
even when TYPO3 is not set up yet.

This is achieved by always executing commands uncached,
thus corrupted caches won't harm command line execution any more
and only booting to full extent if TYPO3 is set up.

This basically replicates the behaviour of the install tool,
which makes sense, because the install tool is management web ui
and the cli tool is a command line management interface.

Individual commands might still fail, but this failure (exception)
is caught and an error message is shown that guides users
through possible reasons about the failure.

The binary and command dispatcher however are now always
able to be invoked and all Symfony commands from active
extensions are shown.

It is important to note though, that now running any command
will never cause file caches to be generated and, since
booting of TYPO3 has been delayed after the point where
Symfony commands are instanciated, it means that accessing
certain TYPO3 API will not work in the commands constructor.
Access to TYPO3 API should happen earliest in the configure
method.

The complementing patch to typo3/cms-cli is
available as PR on https://github.com/TYPO3/cms-cli/pull/5

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 13