Review main Merged

58301[BUGFIX] Do not mark wizards implementing RepeatableInterface done

Christian Kuhn CR +2 V +2 Easy +16 −5 updated 09/18/18, 18:04

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Christian Kuhn uploaded patch set 1 09/17/18, 11:04

  2. Andreas Kienast voted on patch set 1 CR +1 09/17/18, 11:06

  3. Oliver Klee commented on patch set 1 09/17/18, 11:07

    UpgradeWizardRunCommand.php:158

    Shouldn't the wizard know about whether it can be really done instead of the RunCommand?
  4. TYPO3com voted on patch set 1 V +1 09/17/18, 11:14 Completed build in 09m 44s on Mon, 17 Sep, 01:14 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28220

  5. Christian Kuhn commented on patch set 1 09/17/18, 11:28

    UpgradeWizardRunCommand.php:158 Reply

    the interfaces are there to have that controllable from the outside. it was 'internal' before and that was not a good solution that created more problems than good.
  6. Susi Moog commented on patch set 1 09/17/18, 16:16

    UpgradeWizardRunCommand.php:235

    this output line should be there in any case, as it's the success message that the wizard has run.
  7. Christian Kuhn uploaded patch set 2 09/17/18, 19:54

  8. TYPO3com voted on patch set 2 V +1 09/17/18, 20:03 Completed build in 08m 03s on Mon, 17 Sep, 10:03 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28247

  9. Susi Moog voted on patch set 2 V +1 CR +1 09/18/18, 06:29

  10. Benni Mack voted on patch set 2 V +2 CR +2 09/18/18, 18:04

  11. Benni Mack merged patch set 3 09/18/18, 18:04