Review main Merged

58309[TASK] Mark internal $TSFE properties as protected

Benni Mack CR +2 V +2 Normal +164 −11 updated 09/20/18, 03:23

Commit message

Due to some PHP4 legacy code, most properties in TSFE
were Public API. As some arguments are only used internally
within TSFE and _should_ only used internally, their
visibility has been modified to be protected, and the properties
themselves have also an additional @internal annotation.

For v9, accessing the properties from the outside will still
work but trigger a deprecation message.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3