Review main Merged

58416[BUGFIX] FailsafePackageManager: do not prevent package sorting

Benjamin Franzke CR +2 V +2 Easy +18 −7 updated 09/28/18, 10:33

Commit message

FailsafePackageManager prevents saving PackageStates.php in
failsafe mode by overwriting sortAndSavePackageStates(). That works
to prevent saving, but also prevents sorting when initially loading
packages when PackageStates.php is missing.

Currently this does not really produce problems, as the install
tool creates a new PackageStates.php later on and saves (and
implicitly sorts them) using forceSortAndPackageStates().

To fix the intermediate state we now only prevent saving,
but not the sorting of packages.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2