Review main Merged

58505[TASK] Improve code to avoid Scrutinizer warnings

Markus Klein CR +2 V +2 Easy +13 −7 updated 10/01/18, 13:34

Commit message

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Stefan Neufeind +1
    • Stephan Großberndt +1
    • Jan Stockfisch +1
    • Benni Mack +1
  • Verified V +2
    • Benni Mack +2
    • Andreas Wolf +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1519

  1. Markus Klein uploaded patch set 1 09/30/18, 16:23

  2. TYPO3com voted on patch set 1 V -1 09/30/18, 16:24 Completed build in 13s on Sun, 30 Sep, 06:24 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29042

  3. Markus Klein uploaded patch set 2 09/30/18, 16:26

  4. TYPO3com voted on patch set 2 V -1 09/30/18, 16:26 Completed build in 10s on Sun, 30 Sep, 06:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29043

  5. Markus Klein uploaded patch set 3 09/30/18, 16:30

  6. Stephan Großberndt voted on patch set 3 CR +1 09/30/18, 16:33

  7. TYPO3com voted on patch set 3 V +1 09/30/18, 16:41 Completed build in 11m 01s on Sun, 30 Sep, 06:41 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29045

  8. Tymoteusz Motylewski commented on patch set 3 09/30/18, 17:24

    LazyLoadingProxy.php:75

    I would rather change scrunitizer rules than change this code.
  9. Markus Klein commented on patch set 3 09/30/18, 17:59

    LazyLoadingProxy.php:75 Reply

    Fine with me, I prefer the former version anyways.
  10. Markus Klein commented on patch set 4 09/30/18, 18:00

    Published edit on patch set 3.
  11. TYPO3com voted on patch set 4 V +1 09/30/18, 18:12 Completed build in 12m 43s on Sun, 30 Sep, 08:12 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29055

  12. Benni Mack voted on patch set 4 CR +1 09/30/18, 19:14

  13. Stephan Großberndt voted on patch set 4 CR +1 10/01/18, 05:22

  14. Stefan Neufeind voted on patch set 4 CR +1 10/01/18, 07:23

  15. Jan Stockfisch voted on patch set 4 CR +1 10/01/18, 09:17

  16. Andreas Wolf commented on patch set 4 CR +2 10/01/18, 10:18

    Going to test this now by applying and trying if Extbase persistence still works.
  17. Andreas Wolf voted on patch set 4 V +1 10/01/18, 10:41

  18. Benni Mack voted on patch set 4 V +2 10/01/18, 13:34

  19. Benni Mack merged patch set 5 10/01/18, 13:34