Review main Merged

58539[BUGFIX] Fix decrementing of AJAX requests in extension scanner

Andreas Kienast CR +2 V +2 Normal +67 −40 updated 10/01/18, 20:15

Commit message

The queueing of AJAX requests in the extension scanner has some flaws
which causes the scanner to refuse another scan request.

The counter of pending requests is now always decremented, not only if
the amount of requests equals the threshold. Also, it's now checked if
there is any item in the request queue before shifting.

Instead of overriding the `success` and `error` callback, only `complete`
is now overridden, as this callback is executed on any return state.

To make the queueing part better maintainable and reusable, the code has
been moved into a separate module.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2