Review main Merged

58540[BUGFIX] XmlSitemapRenderer should use TSFE->type for page-type

Stefan Neufeind CR +2 V +2 Easy +1 −1 updated 10/01/18, 20:02

Commit message

When the new PageTypeEnhancer resolved type from a URL it is
not part of getQueryParams() but needs to be fetched from TSFE.

Review

  • Code review CR +2
    • Markus Klein +2
    • Benni Mack +1
  • Verified V +2
    • Markus Klein +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Stefan Neufeind uploaded patch set 1 10/01/18, 19:21

  2. TYPO3com voted on patch set 1 V +1 10/01/18, 19:34 Completed build in 13m 22s on Mon, 1 Oct, 09:34 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29226

  3. Benni Mack voted on patch set 1 V +1 CR +1 10/01/18, 19:42

  4. Markus Klein voted on patch set 1 V +2 CR +2 10/01/18, 20:02

  5. Markus Klein merged patch set 2 10/01/18, 20:02